fix(TabControl): error when placed #67

Merged

abart27 merged 1 commit from fix-tab-control-crash into main

2026-03-21 12:50:58 +00:00

abart27 commented

2026-03-21 12:49:15 +00:00

(Migrated from github.com)

This control is messed up anyway, we need a different paradigm for this kind of nested template control.

copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed

2026-03-21 12:50:50 +00:00

copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment

Pull request overview

Fixes a runtime error in TabControl placement by calling ugui.standard_styler.compute_rich_text with the full expected argument list (including font name/size), aligning the call site with the function’s signature in styler.lua.

Changes:

Update TabControl tab-header width measurement to pass font_name and font_size into compute_rich_text.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

## Pull request overview Fixes a runtime error in `TabControl` placement by calling `ugui.standard_styler.compute_rich_text` with the full expected argument list (including font name/size), aligning the call site with the function’s signature in `styler.lua`. **Changes:** - Update `TabControl` tab-header width measurement to pass `font_name` and `font_size` into `compute_rich_text`. --- 💡 <a href="/mupen64/ugui/new/main?filename=.github/instructions/*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.