chore: put LuaLS config in .luarc.json #49

2026-02-28T15:22:20Z

abart27 commented

2026-02-28 15:22:20 +00:00

(Migrated from github.com)

Moves LuaLS config from .vscode/settings.json to .luarc.json.

Moves LuaLS config from `.vscode/settings.json` to `.luarc.json`.

copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed

2026-02-28 15:24:13 +00:00

copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment

Pull request overview

Moves Lua Language Server (LuaLS) configuration out of editor-specific VS Code workspace settings into a repo-wide .luarc.json so the same settings apply across editors that support LuaLS.

Changes:

Removed LuaLS settings from .vscode/settings.json.
Added .luarc.json with LuaLS schema, runtime version, and formatting/diagnostics settings.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
`.vscode/settings.json`	Removes LuaLS configuration previously stored as VS Code workspace settings.
`.luarc.json`	Introduces centralized LuaLS configuration (schema, runtime, formatting, diagnostics).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

## Pull request overview Moves Lua Language Server (LuaLS) configuration out of editor-specific VS Code workspace settings into a repo-wide `.luarc.json` so the same settings apply across editors that support LuaLS. **Changes:** - Removed LuaLS settings from `.vscode/settings.json`. - Added `.luarc.json` with LuaLS schema, runtime version, and formatting/diagnostics settings. ### Reviewed changes Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments. | File | Description | | ---- | ----------- | | `.vscode/settings.json` | Removes LuaLS configuration previously stored as VS Code workspace settings. | | `.luarc.json` | Introduces centralized LuaLS configuration (schema, runtime, formatting, diagnostics). | --- 💡 <a href="/mupen64/ugui/new/main?filename=.github/instructions/*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.

.luarc.json

					
				@ -0,0 +11,4 @@

				    "max_line_length": "8000",

				    "trailing_table_separator": "smart",

				    "detect_end_of_line": "false",

				    "insert_final_newline": "true",

This migration is not equivalent to the prior VS Code settings: the previous formatter config set end_of_line to crlf, but that option is missing from the new format.defaultConfig. If CRLF output is required (especially on Windows), add end_of_line back so formatting doesn’t change unexpectedly.

This migration is not equivalent to the prior VS Code settings: the previous formatter config set `end_of_line` to `crlf`, but that option is missing from the new `format.defaultConfig`. If CRLF output is required (especially on Windows), add `end_of_line` back so formatting doesn’t change unexpectedly.

.luarc.json

					
				@ -0,0 +41,4 @@

				  },

				  "diagnostics.disable": [

				    "lowercase-global"

				  ]

This PR description says it moves the existing LuaLS config, but .luarc.json drops the previously configured diagnostics.globals (e.g., wgui, d2d, emu). If those globals are still expected, add them back under "diagnostics.globals" to preserve the prior diagnostics behavior.

This PR description says it moves the existing LuaLS config, but `.luarc.json` drops the previously configured `diagnostics.globals` (e.g., `wgui`, `d2d`, `emu`). If those globals are still expected, add them back under `"diagnostics.globals"` to preserve the prior diagnostics behavior.

Sign in to join this conversation.

No reviewers